lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12516) JSON "range" facets can incorrectly refine subfacets for buckets
Date Fri, 06 Jul 2018 16:35:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535086#comment-16535086
] 

ASF subversion and git services commented on SOLR-12516:
--------------------------------------------------------

Commit 7d8ef9e39d3321a5366fcfe1a358ec015fb7b8b1 in lucene-solr's branch refs/heads/master
from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d8ef9e ]

SOLR-12516: Fix some bugs in 'type:range' Facet refinement when sub-facets are combined with
non default values for the 'other' and 'include' options.

1) the optional other buckets (before/after/between) are not considered during refinement

2) when using the include option: if edge is specified, then the refinement of all range buckets
mistakenly includes the lower bound of the range, regardless of whether lower was specified.


> JSON "range" facets can incorrectly refine subfacets for buckets
> ----------------------------------------------------------------
>
>                 Key: SOLR-12516
>                 URL: https://issues.apache.org/jira/browse/SOLR-12516
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>         Attachments: SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch,
SOLR-12516.patch, SOLR-12516.patch, SOLR-12516.patch
>
>
> while simple {{type:range}} facets don't benefit from refinement, because every shard
returns the same set of buckets, some bugs currently exist when a range facet contains sub
facets that use refinement:
> # the optional {{other}} buckets (before/after/between) are not considered during refinement
> # when using the {{include}} option: if {{edge}} is specified, then the refinement of
all range buckets mistakenly includes the lower bound of the range, regardless of whether
{{lower}} was specified.
> ----
> #1 occurs because {{FacetRangeMerger extends FacetRequestSortedMerger<FacetRange>}}
... however {{FacetRangeMerger}} does not override {{getRefinement(...)}} which means only
{{FacetRequestSortedMerger.buckets}} is evaluated and considered for refinement. The additional,
special purpose, {{FacetBucket}} instances tracked in {{FacetRangeMerger}} are never considered
for refinement.
> #2 exists because of a mistaken in the implementation of {{refineBucket}} and how it
computes the {{start}} value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message