lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8394) TieredMergePolicy's handling of the case that all segments are less than the floor segment size is fragile
Date Tue, 10 Jul 2018 07:29:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538174#comment-16538174
] 

ASF subversion and git services commented on LUCENE-8394:
---------------------------------------------------------

Commit a864ef823167380eb1e2724b453c7730b93f5bbe in lucene-solr's branch refs/heads/master
from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a864ef8 ]

LUCENE-8394: Explicitly handle the case when segments are smaller than the floor size.


> TieredMergePolicy's handling of the case that all segments are less than the floor segment
size is fragile
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8394
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8394
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-8394.patch
>
>
> In the case that the index size is less than the floor segment size, the allowed number
of segments is always computed as 1. In practice, it doesn't keep merging indefinitely only
because {{doFindMerges}} has some logic that skips merging if the number of candidates is
less than maxMergeAtOnce. This looks a bit fragile to me.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message