lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #455: WIP: SOLR-12638
Date Tue, 18 Sep 2018 04:08:08 GMT
Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/455#discussion_r218293921
  
    --- Diff: solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
---
    @@ -1184,7 +1196,16 @@ protected boolean versionAdd(AddUpdateCommand cmd) throws IOException
{
     
             // TODO: possibly set checkDeleteByQueries as a flag on the command?
             doLocalAdd(cmd);
    -        
    +
    +        if(lastKnownVersion != null && req.getSchema().isUsableForChildDocs()
&&
    --- End diff --
    
    This may very well be right but can you tell me why you added this delete here at this
line and why the delete is version-dependent?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message