lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <>
Subject [jira] [Commented] (LUCENE-5143) rm or formalize dealing with "general" KEYS files in our dist dir
Date Fri, 07 Sep 2018 23:41:00 GMT


Jan Høydahl commented on LUCENE-5143:

Attached patch [^LUCENE-5143-reopen-smoke.patch] with changes to
 * Pulls {{KEYS}} from [] instead of {{<staging-folder>/{lucene,solr}}}
 * Barfs if {{KEYS}} file is present in {{<staging-folder>/{lucene,solr}}}
 * Optionally takes {{--local-keys <file>}} argument to use locally cached KEYS file

Also some changes to build-files. I believe this is dead code related to staging RCs to
which is no longer in use but superseded by Please correct me if
I'm wrong:
 * Removes targets {{stage}}, {{copy-to-stage}} and {{-dist-keys}} from {{lucene/build.xml}}
 * Removes targets {{copy-to-stage}} and {{-dist-keys}} from {{solr/build.xml}}
 * Removes macro {{copy-to-stage-macro}} from {{lucene/common-build.xml}}

None of this is tested. [~jim.ferenczi] - I'll try to test the smnoketester before the first
7.5 RC.

> rm or formalize dealing with "general" KEYS files in our dist dir
> -----------------------------------------------------------------
>                 Key: LUCENE-5143
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Hoss Man
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 7.5, master (8.0)
>         Attachments: KEYS, KEYS, KEYS, KEYS, LUCENE-5143-reopen-smoke.patch, LUCENE-5143.patch,
LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143_READMEs.patch, LUCENE-5143_READMEs.patch,
LUCENE-5143_READMEs.patch, LUCENE_5143_KEYS.patch, verify.log,,,
> At some point in the past, we started creating a snapshots of KEYS (taken from the auto-generated
data from in the release dir of each release...
> etc...
> But we also still have some "general" KEYS files...
> ...which (as i discovered when i went to add my key to them today) are stale and don't
seem to be getting updated.
> I vaguely remember someone (rmuir?) explaining to me at one point the reason we started
creating a fresh copy of KEYS in each release dir, but i no longer remember what they said,
and i can't find any mention of a reason in any of the release docs, or in any sort of comment
> we probably do one of the following:
>  * remove these "general" KEYS files
>  * add a disclaimer to the top of these files that they are legacy files for verifying
old releases and are no longer used for new releases
>  * ensure these files are up to date stop generating per-release KEYS file copies
>  * update our release process to ensure that the general files get updated on each release
as well

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message