lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <>
Subject [jira] [Commented] (LUCENE-5143) rm or formalize dealing with "general" KEYS files in our dist dir
Date Mon, 10 Sep 2018 22:38:00 GMT


Jan Høydahl commented on LUCENE-5143:

New version of [^LUCENE-5143-reopen-smoke.patch]
 * Fixes in
 ** Fixed bug in GPG key check against KEYS, new regex pattern
 ** Check that GPG key is in KEYS file before asking for GPG pasphrase
 ** Abort script if 'git log origin/<branch>' command fails
 * Tested including support for --local-keys
 * Fixed typo in dev-tools/doap/solr.rdf - release 7.4.1 -> 7.4.0

I'll commit this tomorrow. I'm removing the copy-to-stage target and friends from ant build
scripts since they are old and out of date - unless someone really want them there for some
specific reason (and want to maintain the code).

> rm or formalize dealing with "general" KEYS files in our dist dir
> -----------------------------------------------------------------
>                 Key: LUCENE-5143
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Hoss Man
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 7.5, master (8.0)
>         Attachments: KEYS, KEYS, KEYS, KEYS, LUCENE-5143-reopen-smoke.patch, LUCENE-5143-reopen-smoke.patch,
LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143_READMEs.patch,
LUCENE-5143_READMEs.patch, LUCENE-5143_READMEs.patch, LUCENE_5143_KEYS.patch, verify.log,,,
> At some point in the past, we started creating a snapshots of KEYS (taken from the auto-generated
data from in the release dir of each release...
> etc...
> But we also still have some "general" KEYS files...
> ...which (as i discovered when i went to add my key to them today) are stale and don't
seem to be getting updated.
> I vaguely remember someone (rmuir?) explaining to me at one point the reason we started
creating a fresh copy of KEYS in each release dir, but i no longer remember what they said,
and i can't find any mention of a reason in any of the release docs, or in any sort of comment
> we probably do one of the following:
>  * remove these "general" KEYS files
>  * add a disclaimer to the top of these files that they are legacy files for verifying
old releases and are no longer used for new releases
>  * ensure these files are up to date stop generating per-release KEYS file copies
>  * update our release process to ensure that the general files get updated on each release
as well

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message