lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer
Date Mon, 03 Sep 2018 12:17:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602097#comment-16602097
] 

Adrien Grand commented on LUCENE-6228:
--------------------------------------

+1 to this patch, let's also make sure we add a note about this to the MIGRATE.txt? It would
be a nice addition to Lucene 8 since we added more methods that shouldn't get called from
a collector, like advanceShallow and getMaxScore. However we'd need to put setMinCompetitiveScore
on Scorable.

> Do not expose full-fledged scorers in LeafCollector.setScorer
> -------------------------------------------------------------
>
>                 Key: LUCENE-6228
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6228
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Major
>             Fix For: 5.2, 6.0
>
>         Attachments: LUCENE-6228.patch, LUCENE-6228.patch, LUCENE-6228.patch, LUCENE-6228.patch,
LUCENE-6228.patch
>
>
> Currently LeafCollector.setScorer takes a Scorer, which I don't like because several
methods should never be called in the context of a Collector (like nextDoc or advance).
> I think it's even more trappy for methods that might seem to work in some particular
cases but will not work in the general case, like getChildren which will not work if you have
a specialized BulkScorer or iterating over positions which will not work if you are in a MultiCollector
and another leaf collector consumes positions too.
> So I think we should restrict what can be seen from a collector to avoid such traps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message