lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9317) ADDREPLICA command should be more flexible and add 'n' replicas to a collection,shard
Date Tue, 18 Sep 2018 09:37:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618771#comment-16618771
] 

Shalin Shekhar Mangar commented on SOLR-9317:
---------------------------------------------

This turned out to be a bigger rabbit hole than I imagined. A lot of changes were required.
# Add Replica API now supports nrtReplicas, pullReplicas, tlogReplicas, createNodeSet parameters
# Create Shard API supports nrtReplicas, pullReplicas, tlogReplicas parameters
# Support for the new parameters have been added in corresponding SolrJ classes.
# CreateShardCmd delegates adding replicas entirely to Add Replica API
# CreateShardCmd cleans up slices from cluster state in case an AssignmentException is thrown
by the Add Replica API
# Refactorings were required in Add Replica API to break the huge monolithic method into smaller
ones e.g. finding replica positions, assigning and validating core names and actual creation
of cores are now separate methods
# Fixed a bug in {{TestSimPolicyCloud.testCreateCollectionAddShardWithReplicaTypeUsingPolicy}}
which was using the same node as target for tlog and pull replicas.
# New test method in AddReplicaTest asserts creating multiple replicas together

There is still one failure in SplitShard API with rules that I trying to track down. Rest
all tests pass.

> ADDREPLICA command should be more flexible and add 'n' replicas to a collection,shard
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-9317
>                 URL: https://issues.apache.org/jira/browse/SOLR-9317
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: 6.1
>
>         Attachments: SOLR-9317.patch
>
>
> It should automatically identify the nodes where these replicas should be created as
well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message