lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (SOLR-12055) Enable async logging by default
Date Sat, 08 Sep 2018 03:23:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Erick Erickson reopened SOLR-12055:
-----------------------------------

Things have gone soooo wonky today, more than a few "SuppressSysoutChecks" messages in test
failures and a _bunch_ of other stuff. I doubt the async logging is to blame for a majority
of the other errors, but it's certainly adding to the noise. If this was all primarily async
logging it should have been exploding all this week.

However, given [~dsmiley]'s comments on the SuppresSysoutChecks error, the number of SuppressSysoutCheck
errors I've seen today and [~ab@getopt.org]'s comments on his edge-case with OOMs (SOLR-12753),
I think this change should wait until after 7.5 is cut and we have some time to shake out
the issues before this is in a release. 

Synchronous logging has been working fine for 10 years. I'd rather wait a couple of months
for this optimization to hit the street than rush it out the door and have failures in the
wild.

I'll back this change out on master and 7x momentarily. Any problems after midnight Pacific
time (UTC-8) are "something else".

 

> Enable async logging by default
> -------------------------------
>
>                 Key: SOLR-12055
>                 URL: https://issues.apache.org/jira/browse/SOLR-12055
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: logging
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: master (8.0), 7.5
>
>         Attachments: SOLR-12055-slh-interim1.patch, SOLR-12055-slh-interim1.patch, SOLR-12055.patch,
SOLR-12055.patch
>
>
> When SOLR-7887 is done, switching to async logging will be a simple change to the config
files for log4j2. This will reduce contention and increase throughput generally and logging
in particular.
> There's a discussion of the pros/cons here: https://logging.apache.org/log4j/2.0/manual/async.html
> An alternative is to put a note in the Ref Guide about how to enable async logging.
> I guess even if we enable async by default the ref guide still needs a note about how
to _disable_ it.....



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message