lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries
Date Mon, 03 Sep 2018 12:49:00 GMT


Adrien Grand commented on LUCENE-8422:

+1 to the patch in general, only two minor comments:
 - Maybe we should put some of the helpers that you are adding like IntervalIterator#wrapMatches
or MatchesIterator#disjunction to separate classes to keep IntervalIterator and MatchesIterator
only about consuming iterators/matches? I think that would make the API easier to digest.
 - Should IntervalIterator#wrapMatches return an iterator whose doc ID is initially -1? Also
#docID() should return NO_MORE_DOCS after nextDoc/advance returned NO_MORE_DOCS.

FYI precommit complains about unused imports.

> Add Matches iteration to interval queries
> -----------------------------------------
>                 Key: LUCENE-8422
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8422.patch, LUCENE-8422.patch
> Follow up to LUCENE-8404, we can now add Matches iteration to interval queries in the

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message