lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12652) SolrMetricManager.overridableRegistryName should be removed; it doesn't work
Date Thu, 27 Sep 2018 19:41:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630958#comment-16630958
] 

ASF subversion and git services commented on SOLR-12652:
--------------------------------------------------------

Commit 044bc2a48522cb9d1e112aa3be4f2d7e6c2ed498 in lucene-solr's branch refs/heads/master
from [~psomogyi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=044bc2a ]

SOLR-12652: Remove SolrMetricManager.overridableRegistryName()


> SolrMetricManager.overridableRegistryName should be removed; it doesn't work
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-12652
>                 URL: https://issues.apache.org/jira/browse/SOLR-12652
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.1
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: SOLR-12652.patch, SOLR-12652.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{SolrMetricManager.overridableRegistryName()}} method is a great idea but unfortunately
in practice I've found it doesn't really work; it seems fundamentally flawed.  +I wish it
could work+.  The main issue I think is that the callers of SMM.registerGauge/registerMetric
assumes it can place a gauge/metric and have it be the only once there (force==true).  But
it won't be if it's shared.  
> Another problem is in at least one of the reporters -- {{JmxMetricsReporter.JmxListener#registerMBean}}
will get in a race condition to remove an already-registered MBean but in the process of removing
it, it'll already get removed concurrently by some other core working on the same name.  This
results in {{javax.management.InstanceNotFoundException}} logged as a warning; nothing serious.
 But I suspect conceptually there is a problem since which MBean should "win"?  Shrug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message