lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mosh (JIRA)" <>
Subject [jira] [Commented] (SOLR-12685) RTG should return the whole block if schema is nested
Date Mon, 03 Sep 2018 07:39:00 GMT


mosh commented on SOLR-12685:

Please correct me if mistaken.
 I was thinking RTG should not return the whole block when queried directly by the RTG handler,
but rather should explicitly perform these checks when running RealTimeGetComponent#getInputDocument,
which is used by AtomicUpdateDocumentMerger.
SolrInputDocument oldDocument = RealTimeGetComponent.getInputDocument
      (cmd.getReq().getCore(), idBytes,
       null, // don't want the version to be returned
       true, // avoid stored fields from index
       true); // resolve the full document{code}
Unless, of course, RTG block lookup is needed by the replication process, which, unfortunately,
I am unfamiliar with.
Running through the code it seems like the transaction log lookup is written in RealTimeGetComponent#getInputDocumentFromTlog
and in process, twice.
We could leverage that to ensure AtomicUpdateDocumentMerger gets the block when needed, avoiding
further collision and interference with the RealTimeGetHandler.

> RTG should return the whole block if schema is nested
> -----------------------------------------------------
>                 Key: SOLR-12685
>                 URL:
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12638-no-commit.patch
> Currently Solr's RealTimeGet component return the document if provided a docId when consulting
the index. For AtomicUpdates for child documents, RTG should return the whole block when dealing
with a nested schema.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message