lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12727) Upgrade ZooKeeper dependency to 3.4.13
Date Thu, 13 Sep 2018 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613842#comment-16613842
] 

Erick Erickson commented on SOLR-12727:
---------------------------------------

[~risdenk] Thanks a million for looking at this, it'd have taken me, well, quite a while to
try to figure out.

I think many uses of 127.0.0.1 are just accidental. At least not conscious choices. And once
it's in the code base it gets repeated.

And I'm sooooo glad I didn't try to shoehorn this into Solr 7.5. For instance, 'bin/solr zk
-e cloud' doesn't work any more, we get "Could not connect to ZooKeeper localhost:2181 within
30000 ms". Who knows what else?

What worked for me for the one test was just changing {{127.0.0.1}} to {{localhost}} in both
{{SaslZkACLProviderTest}} and {{ZkTestServer}}. 

I haven't run the rest of the test suite yet and I'll beast {{SSLMigrationTest}} to see what
falls out.

All that said, this really calls into question how to proceed. I don't particularly care about
changing the _tests_, but have concerns about how this affects people who upgrade. I'll solicit
opinions on the dev list.

Again, many many thanks for helping out here, I wouldn't have known where to start looking.


> Upgrade ZooKeeper dependency to 3.4.13
> --------------------------------------
>
>                 Key: SOLR-12727
>                 URL: https://issues.apache.org/jira/browse/SOLR-12727
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 7.4
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12727.patch
>
>
> Upgrade ZK dependency to 3.4.13.  This fixes ZOOKEEPER-2184 which will make the ZK client
re-resolve the server hostnames when a connection fails.  This will fix issues where a failed
ZK container is replaced with a new one that has a different IP address and DNS gets updated
with the new address.
> Typically these upgrades do not require code changes, but that should be verified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message