lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8478) combine TermScorer constructors' implementation
Date Thu, 06 Sep 2018 13:09:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605745#comment-16605745
] 

Adrien Grand commented on LUCENE-8478:
--------------------------------------

bq. so not sure if this is worth pursuing further or not.

Another problem is that one reason why things are the way they are today is to avoid wrapping
the postings iterator whenever possible for performance reasons. The latest patch always wraps
it with a SlowImpactsEnum + ImpactsDISI. I'm leaning towards keeping things the way they are
today.

> combine TermScorer constructors' implementation
> -----------------------------------------------
>
>                 Key: LUCENE-8478
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8478
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: master (8.0)
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: LUCENE-8478.patch, LUCENE-8478.patch
>
>
> We currently have two {{TermScorer}} constructor variants and it's not immediately obvious
how and why their implementations are the way they are as far as initialisations and initialisation
order is concerned. Combination of the logic could make the commonalities and differences
clearer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message