lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8478) combine TermScorer constructors' implementation
Date Mon, 03 Sep 2018 21:08:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602446#comment-16602446
] 

Adrien Grand commented on LUCENE-8478:
--------------------------------------

I'm not sure this is a net win since it requires the addition of a 3rd constructor, which
has a bizarre API since you need to pass null as the iterator to use the ImpactsDisi while
it would be more natural to expect callers to pass the ImpactsDisi instead, even though I
understand why it is not possible here. Maybe we could clarify with comments instead?

> combine TermScorer constructors' implementation
> -----------------------------------------------
>
>                 Key: LUCENE-8478
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8478
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: master (8.0)
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: LUCENE-8478.patch
>
>
> We currently have two {{TermScorer}} constructor variants and it's not immediately obvious
how and why their implementations are the way they are as far as initialisations and initialisation
order is concerned. Combination of the logic could make the commonalities and differences
clearer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message