lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8483) Enforce that Scorer cannot have a null Weight
Date Tue, 04 Sep 2018 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603002#comment-16603002
] 

Adrien Grand commented on LUCENE-8483:
--------------------------------------

Can we somehow avoid the FakeWeight in ValuesSourceScorer? They look created via a FunctionScoreQuery
most of the time, so we should have a weight object available?

I'm also wondering whether we should consider another name: FakeScorer used to be a hack since
it didn't really implement the Scorer API, while FakeScorable is now a pefectly legitimate
implementation of Scorable?

> Enforce that Scorer cannot have a null Weight
> ---------------------------------------------
>
>                 Key: LUCENE-8483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8483
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8483.patch
>
>
> Follow up to LUCENE-6228.  All Scorers that were passing null as their parent Weights
can be replaced by Scorables, so we can now enforce that Scorer must not have a null Weight.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message