lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12756) Refactor Assign and extract replica placement strategies out of it
Date Fri, 28 Sep 2018 02:19:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631269#comment-16631269
] 

ASF subversion and git services commented on SOLR-12756:
--------------------------------------------------------

Commit c587410f99375005c680ece5e24a4dfd40d8d3eb in lucene-solr's branch refs/heads/jira/http2
from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c587410 ]

SOLR-12756: Refactor Assign and extract replica placement strategies out of it.

Now, assignment is done with the help of a builder class instead of calling a method with
large number of arguments. The number of special cases that had to be handled have been cut
down as well.


> Refactor Assign and extract replica placement strategies out of it
> ------------------------------------------------------------------
>
>                 Key: SOLR-12756
>                 URL: https://issues.apache.org/jira/browse/SOLR-12756
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 7.6, master (8.0)
>
>         Attachments: SOLR-12756.patch, SOLR-12756.patch, SOLR-12756.patch, SOLR-12756.patch
>
>
> While working on SOLR-12648, I found Assign class to be very complex. Many methods have
overlapping functionality, differ in side-effects and have non-intuitive arguments. We should
clean this up and extract replica placement strategies out of that class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message