lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8505) IndexWriter#addIndices should not sort indices if they are not already sorted
Date Tue, 25 Sep 2018 07:15:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626901#comment-16626901
] 

ASF subversion and git services commented on LUCENE-8505:
---------------------------------------------------------

Commit 2bad3c498517120c8aaaf805fd49a5cb459417c0 in lucene-solr's branch refs/heads/master
from [~jim.ferenczi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2bad3c4 ]

LUCENE-8505: IndexWriter#addIndices will now fail if the target index is sorted but the candidate
is not.


> IndexWriter#addIndices should not sort indices if they are not already sorted
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-8505
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8505
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jim Ferenczi
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-8505.patch
>
>
> Today IndexWriter#addIndices silently re-sort non-sorted indices when they are added
in a sorted index. This is not safe because the sort is done entirely in memory and cannot
handle big segments efficiently. This leniency was added because prior to 6.5, segments produced
by flushes were not sorted, they had to wait for a merge to apply the index sorting. Now that
segments are always sorted (LUCENE-7579) we should remove this ability and throw an error
if the sort of the current index does not match with the candidate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message