From dev-return-332915-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org Mon Sep 3 12:49:03 2018 Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 96D6E19DA7 for ; Mon, 3 Sep 2018 12:49:03 +0000 (UTC) Received: (qmail 57698 invoked by uid 500); 3 Sep 2018 12:49:02 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 57630 invoked by uid 500); 3 Sep 2018 12:49:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 57620 invoked by uid 99); 3 Sep 2018 12:49:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Sep 2018 12:49:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 53EED1A0819 for ; Mon, 3 Sep 2018 12:49:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qS8xiDgsKr6e for ; Mon, 3 Sep 2018 12:49:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0C0A65F3AC for ; Mon, 3 Sep 2018 12:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4E653E0112 for ; Mon, 3 Sep 2018 12:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0AC082183D for ; Mon, 3 Sep 2018 12:49:00 +0000 (UTC) Date: Mon, 3 Sep 2018 12:49:00 +0000 (UTC) From: "Adrien Grand (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8422) Add Matches iteration to interval queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602118#comment-16602118 ] Adrien Grand commented on LUCENE-8422: -------------------------------------- +1 to the patch in general, only two minor comments: - Maybe we should put some of the helpers that you are adding like IntervalIterator#wrapMatches or MatchesIterator#disjunction to separate classes to keep IntervalIterator and MatchesIterator only about consuming iterators/matches? I think that would make the API easier to digest. - Should IntervalIterator#wrapMatches return an iterator whose doc ID is initially -1? Also #docID() should return NO_MORE_DOCS after nextDoc/advance returned NO_MORE_DOCS. FYI precommit complains about unused imports. > Add Matches iteration to interval queries > ----------------------------------------- > > Key: LUCENE-8422 > URL: https://issues.apache.org/jira/browse/LUCENE-8422 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Attachments: LUCENE-8422.patch, LUCENE-8422.patch > > > Follow up to LUCENE-8404, we can now add Matches iteration to interval queries in the sandbox. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org