lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mayya-sharipova <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #460: LUCENE-8497: refactor multi-term analysis han...
Date Mon, 01 Oct 2018 12:26:35 GMT
Github user mayya-sharipova commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/460#discussion_r221589543
  
    --- Diff: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ScandinavianFoldingFilterFactory.java
---
    @@ -51,7 +49,7 @@ public ScandinavianFoldingFilter create(TokenStream input) {
       }
     
       @Override
    -  public AbstractAnalysisFactory getMultiTermComponent() {
    -    return this;
    +  public ScandinavianFoldingFilter normalize(TokenStream input) {
    --- End diff --
    
    Thanks Alan. I was just following `create` method pattern: 
    `public ScandinavianFoldingFilter create(TokenStream input)`, 
    but happy to change the return type to `TokenStream` according to your suggestion. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message