lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gerlowskija <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #464: WIP SOLR-12555: refactor tests in package org...
Date Mon, 22 Oct 2018 19:26:27 GMT
Github user gerlowskija commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/464#discussion_r227021582
  
    --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java ---
    @@ -1190,14 +1190,8 @@ public void testCompares() throws Exception {
         assertFuncEquals("gte(foo_i,2)", "gte(foo_i,2)");
         assertFuncEquals("eq(foo_i,2)", "eq(foo_i,2)");
     
    -    boolean equals = false;
    -    try {
    -      assertFuncEquals("eq(foo_i,2)", "lt(foo_i,2)");
    -      equals = true;
    -    } catch (AssertionError e) {
    -      //expected
    -    }
    -    assertFalse(equals);
    +    expectThrows(AssertionError.class, "expected error, functions are not equal",
    --- End diff --
    
    [0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message