lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vthacker <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...
Date Tue, 30 Oct 2018 23:37:18 GMT
Github user vthacker commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/486#discussion_r229523672
  
    --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java
---
    @@ -265,10 +281,30 @@ public MiniSolrCloudCluster(int numServers, Path baseDir, String
solrXml, JettyC
         solrClient = buildSolrClient();
       }
     
    -  private void waitForAllNodes(int numServers, int timeout) throws IOException, InterruptedException
{
    +  private void waitForAllNodes(int numServers, int timeoutSeconds) throws IOException,
InterruptedException {
    --- End diff --
    
    Some Javadocs that we could add here :
    
    "This method wait till all Solr JVMs ( Jettys ) are running . It waits upto the timeout
(in seconds) for the JVMs to be up before throwing IllegalStateException"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message