lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From moshebla <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #:
Date Wed, 31 Oct 2018 05:10:50 GMT
Github user moshebla commented on the pull request:

    https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31114379
  
    Perhaps a better name for it would be "isNestedUpdate".
    This method checks whether the update changes a block.
    Beforehand, the previous version was looked up, causing ConvertedLegacyTest to fail.
    Now the test passes, since the look up is only executed when needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message