lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erick Erickson <erickerick...@gmail.com>
Subject Re: [jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.
Date Wed, 31 Oct 2018 15:18:15 GMT
Gus:

1> did you apply to 7x?
2> did you pull before you applied?

It applied cleanly for me doing the exact same process. I did have one
compile issue where a variable was somehow defined twice, but it was
trivial to just take one out.

Erick
On Wed, Oct 31, 2018 at 5:19 AM Gus Heck (JIRA) <jira@apache.org> wrote:
>
>
>     [ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670011#comment-16670011
]
>
> Gus Heck commented on SOLR-12801:
> ---------------------------------
>
> [https://patch-diff.githubusercontent.com/raw/apache/lucene-solr/pull/486.patch] didn't
apply cleanly on a fresh checkout last night, had a bunch of hunks not applied (intellij's
VCS > Apply Patch...).
>
> > Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test
development.
> > --------------------------------------------------------------------------------------------
> >
> >                 Key: SOLR-12801
> >                 URL: https://issues.apache.org/jira/browse/SOLR-12801
> >             Project: Solr
> >          Issue Type: Task
> >      Security Level: Public(Default Security Level. Issues are Public)
> >            Reporter: Mark Miller
> >            Assignee: Mark Miller
> >            Priority: Critical
> >          Time Spent: 50m
> >  Remaining Estimate: 0h
> >
> > A single issue to counteract the single issue adding tons of annotations, the continued
addition of new flakey tests, and the continued addition of flakiness to existing tests.
> > Lots more to come.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message