lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucene/Solr QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7875) Rename or move most of MultiFields
Date Fri, 05 Oct 2018 21:11:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640347#comment-16640347
] 

Lucene/Solr QA commented on LUCENE-7875:
----------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 65 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m  7s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  1m 38s{color} | {color:red}
core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  1m 38s{color} | {color:red}
core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 18s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 12s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 10s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 12s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 10s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 10s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 10s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 10s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 11s{color}
| {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 
8s{color} | {color:green} Release audit (RAT) rat-sources passed {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}  0m  4s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}  0m 18s{color}
| {color:red} Check forbidden APIs check-forbidden-apis failed {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} | {color:red}  0m 18s{color}
| {color:red} Check forbidden APIs check-forbidden-apis failed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m 19s{color} | {color:green}
common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 58s{color} | {color:green}
backward-codecs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 17s{color} | {color:green}
benchmark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 22s{color} | {color:green}
classification in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 35s{color} | {color:green}
codecs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 29m 55s{color} | {color:green}
core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  9s{color} | {color:green}
facet in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 51s{color} | {color:green}
highlighter in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 57s{color} | {color:green}
join in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 18s{color} | {color:green}
memory in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  0s{color} | {color:green}
misc in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  4s{color} | {color:green}
queries in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  7s{color} | {color:green}
queryparser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 56s{color} | {color:green}
sandbox in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 39s{color} | {color:green}
suggest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 58s{color} | {color:green}
test-framework in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 18s{color} | {color:red}
core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 55s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-7875 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942551/LUCENE-7875.patch
|
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns
 |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / eb47099 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
| compile | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-compile-solr_core.txt
|
| javac | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-compile-solr_core.txt
|
| Release audit (RAT) | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-compile-solr_core.txt
|
| Check forbidden APIs | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-check-forbidden-apis-root.txt
|
| Validate source patterns | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-check-forbidden-apis-root.txt
|
| unit | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/artifact/out/patch-unit-solr_core.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/testReport/ |
| modules | C: lucene/analysis/common lucene/backward-codecs lucene/benchmark lucene/classification
lucene/codecs lucene/core lucene/facet lucene/highlighter lucene/join lucene/memory lucene/misc
lucene/queries lucene/queryparser lucene/sandbox lucene/suggest lucene/test-framework solr/core
U: . |
| Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/101/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Rename or move most of MultiFields
> ----------------------------------
>
>                 Key: LUCENE-7875
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7875
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-7875.patch, LUCENE-7875.patch, LUCENE-7875.patch
>
>
> MultiFields.java has a bunch of static methods that provide a single LeafReader's view
over a bunch of things.
> These could perhaps go to ReaderUtil:
> * {{Bits getLiveDocs(IndexReader reader)}}
> * {{FieldInfos getMergedFieldInfos(IndexReader reader)}} (removing "Merged" in its name
which seems inconsistent, or replace with "Multi")
> These could perhaps go to MultiTerms:
> * {{Collection<String> getIndexedFields(IndexReader reader)}}
> * {{Terms getTerms(IndexReader r, String field)}}
> * {{PostingsEnum getTermDocsEnum(IndexReader r, String field, BytesRef term)}}
> Finally, the MultiFields instance itself, implementing {{Fields}} along with the static
utility method {{Fields getFields(IndexReader reader)}} could perhaps remain until we can
finally remove it (or move to a test classpath or something) when there is no more purpose
for Fields.java.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message