lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12801) Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.
Date Wed, 31 Oct 2018 02:58:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669532#comment-16669532
] 

Erick Erickson commented on SOLR-12801:
---------------------------------------

I get a compilation error: 

{quote}
compile-core:
 [mkdir] Created dir: /Users/Erick/apache/solrJiras/master/solr/build/solr-test-framework/classes/java
 [javac] Compiling 53 source files to /Users/Erick/apache/solrJiras/master/solr/build/solr-test-framework/classes/java
 [javac] /Users/Erick/apache/solrJiras/master/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:398:
error: variable numOtherReplicas is already defined in method createJettys(int)
 [javac] int numOtherReplicas = numJettys - getPullReplicaCount() * sliceCount;
 [javac] ^
 [javac] Note: /Users/Erick/apache/solrJiras/master/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
uses or overrides a deprecated API.
 [javac] Note: Recompile with -Xlint:deprecation for details.
 [javac] Note: Some input files use unchecked or unsafe operations.
 [javac] Note: Recompile with -Xlint:unchecked for details.
 [javac] 1 error
{quote}

Trivially fixable, I'm mostly wondering if there's something in your pull request that got
messed up.... Or if I didn't apply it correctly. I fetched it to a patch file and applied
the patch FWIW.

Running tests now.

> Fix the tests, remove BadApples and AwaitsFix annotations, improve env for test development.
> --------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12801
>                 URL: https://issues.apache.org/jira/browse/SOLR-12801
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Critical
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> A single issue to counteract the single issue adding tons of annotations, the continued
addition of new flakey tests, and the continued addition of flakiness to existing tests.
> Lots more to come.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message