lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucene/Solr QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8424) Payload null value exception handling
Date Thu, 01 Nov 2018 16:07:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671810#comment-16671810
] 

Lucene/Solr QA commented on LUCENE-8424:
----------------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 18s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 20s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 20s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 20s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green}
 0m 20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 16s{color} | {color:green}
queries in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  5m 28s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8424 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12934987/LUCENE-8424.patch
|
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns
 |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 05f72a77 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_172 |
|  Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/115/testReport/ |
| modules | C: lucene/queries U: lucene/queries |
| Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/115/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Payload null value exception handling
> -------------------------------------
>
>                 Key: LUCENE-8424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8424
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 7.2, 7.3.1
>            Reporter: Tapan Vaishnav
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch,
LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch
>
>
> If-Condition to check payload null value in _PayloadScoreQuery.java_ was removed in LUCENE-8038.
Because of that, regarding of the payload value, _payloadsSeen_ is always getting increment.
This has compromised the overall score of the document(for instance, as payloadSeens is always
greater than 0, docScore() in _MinPayloadFunction.java_ only returns payloadScore which can
be zero depending on the payload value). Ideally, it should've returned 1 in case of _payload==null_.
> I have added a simple patch to get started, Please let me know if it needs any improvements. 
> Thanks in advance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message