lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12932) ant test (without badapples=false) should pass easily for developers.
Date Thu, 01 Nov 2018 15:40:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671772#comment-16671772
] 

Erick Erickson commented on SOLR-12932:
---------------------------------------

[~risdenk] My question is more whether we should just be running plain "ant test". I'd expect
to see things like the IndexSizeTriggerTest fail for others. I know that test, for instance,
is getting active attention. It seems to be a bear to figure out how to fix though. Don't
want to flood Mark with extraneous junk.

Thanks for the steps though, I was a little nervous about the fact that I had a compilation
error when I applied the patch, so I'll give your process a shot. So far the compile step
didn't fail.

 

[~markrmiller@gmail.com] This brings the problems I reported this morning into question, probably
should ignore them and/or delete the comment,

 

> ant test (without badapples=false) should pass easily for developers.
> ---------------------------------------------------------------------
>
>                 Key: SOLR-12932
>                 URL: https://issues.apache.org/jira/browse/SOLR-12932
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Major
>
> If we fix the tests we will end up here anyway, but we can shortcut this.
> Once I get my first patch in, anyone who mentions a test that fails locally for them
at any time (not jenkins), I will fix it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message