lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-12373) DocBasedVersionConstraintsProcessor doesn't work when schema has required fields
Date Thu, 13 Dec 2018 01:19:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719616#comment-16719616
] 

Tomás Fernández Löbbe commented on SOLR-12373:
----------------------------------------------

Thanks for your review [~hossman], and sorry for the super late response, I got dragged into
other million things. Your comments make total sense (specially about breaking the behavior
of {{DocBasedVersionConstraintsProcessorFactory}}, I didn’t think about it). I like your
suggestion of the tombstone config. In my use case, I want to be able to set a config that
works and I don’t want to worry about changes in the schema (new required fields added,
etc), which is why I suggested the per field-type approach, so I could extend the tombstone
config idea to support, not only field to value mapping but also field type to value (probably
in different sections). Though the field type to value should be for those fields that are
required in the schema only (otherwise, the tombstone will be full of values)

I’m also wondering if what I’m trying to solve is very unique to my use case, and deserves
to be a custom URP instead of complicating the config too much for everyone. Honestly, the
{{protected createTombstoneDocument(…)}} is already a big win, and I could just extend that
single method in a custom plugin. I’m more inclined into this now.

> DocBasedVersionConstraintsProcessor doesn't work when schema has required fields
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-12373
>                 URL: https://issues.apache.org/jira/browse/SOLR-12373
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>            Priority: Minor
>         Attachments: SOLR-12373.patch, SOLR-12373.patch
>
>
> DocBasedVersionConstraintsProcessor creates tombstones when processing a delete by id.
Those tombstones only have id (or whatever the unique key name is) and version field(s), however,
if the schema defines some required fields, adding the tombstone will fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message