lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucene/Solr QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12535) Remove syntax for providing index boosts in Solr's JSON update syntax
Date Mon, 24 Dec 2018 04:57:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728141#comment-16728141
] 

Lucene/Solr QA commented on SOLR-12535:
---------------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 43s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 36s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 36s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  1m 36s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green}
 1m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 37m 13s{color} | {color:green}
core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 13s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12535 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12952937/SOLR-12535.patch
|
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns
 |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1d0a086 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
|  Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/254/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/254/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Remove syntax for providing index boosts in Solr's JSON update syntax
> ---------------------------------------------------------------------
>
>                 Key: SOLR-12535
>                 URL: https://issues.apache.org/jira/browse/SOLR-12535
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Blocker
>             Fix For: master (8.0)
>
>         Attachments: SOLR-12535.patch
>
>
> In Solr 7 we can't index boost as it's gone from Lucene. The JSON support for this syntax
is still allowed but logs a warning and doesn't apply the boost (as it's not supported). I'm
proposing we remove support for this altogether. This also means removing an little-known
way to specify an "extended field value" that doesn't necessarily have a boost.
>  With boost: Today logs a warning. *Don't want this to work at all.*
> {code:java}
> [{'id':'1', 'val_s':{'value':'foo', 'boost':2.0}}]
> {code}
> Without boost: Today works. *Don't want this to work at all,* as it complicates support
for labelled child documents – SOLR-12362.
> {code:java}
> [{'id':'1', 'val_s':{'value':'foo'}}]
> {code}
> Internally this is parsed by
>  org.apache.solr.handler.loader.JsonLoader.SingleThreadedJsonLoader#parseExtendedFieldValue
>  I think we need make no reference to the notion of an "extended field value". Either
we have a "partial update", or we have a "child document"; nothing else.
> [https://lucene.apache.org/solr/guide/7_3/updating-parts-of-documents.html]
> Note: partial updates look similar and have exactly one field-value using a limited set
of verbs like "set":
> {code:java}
> [{'id':'1', 'val_s':{'set':'foo'}}]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message