lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-12791) Add Metrics reporting for AuthenticationPlugin
Date Mon, 10 Dec 2018 10:24:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714536#comment-16714536
] 

Jan Høydahl commented on SOLR-12791:
------------------------------------

Got  [Pull Request #457|https://github.com/apache/lucene-solr/pull/457] up to date with
master. Precommit and tests pass. Beasting {{BasicAuthIntegrationTest}} is ok as long as
{{-Dtests.dups}} is <=3, probably due to the stop/start of random Jetty and only having
3 jettys in cluster, and the fact that the way we assert that metric counters is by asking
the Jetty's - if they get restarted by another parallell test thread the counters would be
cleared and the counts wrong..

Plan to commit current patch to master only on Wednesday.

> Add Metrics reporting for AuthenticationPlugin
> ----------------------------------------------
>
>                 Key: SOLR-12791
>                 URL: https://issues.apache.org/jira/browse/SOLR-12791
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Authentication, metrics
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Propose to add Metrics support for all Auth plugins. Will let abstract {{AuthenticationPlugin}} base
class implement {{SolrMetricProducer}} and keep the counters, such as:
>  * requests
>  * req authenticated
>  * req pass-through (no credentials and blockUnknown false)
>  * req with auth failures due to wrong or malformed credentials
>  * req auth failures due to missing credentials
>  * errors
>  * timeouts
>  * timing stats
> Each implementation still needs to increment the counters etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message