lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
Date Sat, 01 Dec 2018 00:14:00 GMT


ASF subversion and git services commented on SOLR-13030:

Commit a01d0d9ef9cb3d4bbb5a725f9e2aa8dfd9064f95 in lucene-solr's branch refs/heads/master
from markrmiller
[;h=a01d0d9 ]

SOLR-13030: Close MetricsHistoryHandler inline.

> MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
> ----------------------------------------------------------------------------
>                 Key: SOLR-13030
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>            Priority: Major
> {{MetricsHistoryHandler}} implements {{Closeable}} and depends on it's {{close()}} method
to shutdown a {{private ScheduledThreadPoolExecutor collectService}} as well as a {{private
final SolrRrdBackendFactory factory}} (which maintains it's own {{private ScheduledThreadPoolExecutor}}
but -as far as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}} on
shutdown.- after changes in 75b1831967982 which move this close() call to a {{ForkJoinPool}}
in {{CoreContainer.shutdown()}} it seems to be leaking threads.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message