lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
Date Sat, 01 Dec 2018 06:35:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705673#comment-16705673
] 

ASF subversion and git services commented on SOLR-13030:
--------------------------------------------------------

Commit a47b64000b227aae57636877b26f2aa2bc16e1f5 in lucene-solr's branch refs/heads/branch_7x
from [~markrmiller@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a47b640 ]

SOLR-13030: Update executor usage to work correctly with Java 11 and update Mockito &
HttpComponents to work with Java 11 and fix get remote info retry to work across jvms better.

# Conflicts:
#	solr/CHANGES.txt


> MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-13030
>                 URL: https://issues.apache.org/jira/browse/SOLR-13030
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>            Priority: Major
>
> {{MetricsHistoryHandler}} implements {{Closeable}} and depends on it's {{close()}} method
to shutdown a {{private ScheduledThreadPoolExecutor collectService}} as well as a {{private
final SolrRrdBackendFactory factory}} (which maintains it's own {{private ScheduledThreadPoolExecutor}}
but -as far as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}} on
shutdown.- after changes in 75b1831967982 which move this close() call to a {{ForkJoinPool}}
in {{CoreContainer.shutdown()}} it seems to be leaking threads.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message