lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12962) add an 'uninvertible' field(type) option (that defaults to "true" for backcompat)
Date Wed, 09 Jan 2019 21:45:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738681#comment-16738681
] 

David Smiley commented on SOLR-12962:
-------------------------------------

I see an oddity in what we have.  I look in the schema browser and look at a field type that
I _know_ is fundamentally not uninvertible -- a SortableTextField.  To my surprise, I see
a green checkmark under "UnInvertible".  A SortableTextField overrides {{getUninversionType}}
to return null.  A FieldType has two related aspects to its state that together need to be
examined to know if it's uninvertible -- the bit flag and the type getter.  It would be good
to somehow make this consistent or it leads to confusion (as I report here) or perhaps bugs.
 Perhaps setArgs() could call getUninversionType and see if it's null in order to disable
the flag?  Or perhaps better use checkSchemaField().  And if the user explicitly set uninvertible
then throw an error.  WDYT?

> add an 'uninvertible' field(type) option (that defaults to "true" for backcompat)
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-12962
>                 URL: https://issues.apache.org/jira/browse/SOLR-12962
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>             Fix For: 7.6, 8.0
>
>         Attachments: SOLR-12962.patch, SOLR-12962.patch, SOLR-12962.patch, SOLR-12962.patch,
SOLR-12962.patch
>
>
> field & fieldtype declarations should support an {{uninvertible}} option (which defaults
to "true") for backcompat that dictates wether or not Uninversion can be performed on fields.
> See parent issue for more background/discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message