lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13051) Improve TimeRoutedAlias preemptive create to play nice with tests
Date Fri, 11 Jan 2019 20:59:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740784#comment-16740784
] 

David Smiley commented on SOLR-13051:
-------------------------------------

Avoid the CHANGES.txt IMO.  I don't think there's a policy here.  I might be more inclined
to if the person who substantively did the change were a contributor, so as to give a bit
more recognition, but IMO it's better for CHANGES.txt to be a useful document, and an issue
like this is noise that dilutes the usefulness.

BTW thanks for working on this and I like {{SolrCore.runAsync}}

> Improve TimeRoutedAlias preemptive create to play nice with tests
> -----------------------------------------------------------------
>
>                 Key: SOLR-13051
>                 URL: https://issues.apache.org/jira/browse/SOLR-13051
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>    Affects Versions: 8.0, 7.7
>            Reporter: Gus Heck
>            Assignee: Gus Heck
>            Priority: Minor
>         Attachments: SOLR-13051.patch, SOLR-13051.patch
>
>
> SOLR-12801 added AwaitsFix to TimeRoutedAliasUpdateProcessorTest.  This ticket will
fix the test to not require a sleep statement and remove the AwaitsFix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message