lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucene/Solr QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType
Date Tue, 01 Jan 2019 15:53:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731626#comment-16731626
] 

Lucene/Solr QA commented on LUCENE-8601:
----------------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 2 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 43s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 28s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 28s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 46s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green}
 0m 39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 47s{color} | {color:green}
core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 46m 52s{color} | {color:green}
core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 72m 58s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8601 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12953408/LUCENE-8601.06.patch
|
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  validatesourcepatterns
 |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 752989f |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
|  Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/146/testReport/ |
| modules | C: lucene/core solr/core U: . |
| Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/146/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Adding attributes to IndexFieldType
> -----------------------------------
>
>                 Key: LUCENE-8601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8601
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 7.5
>            Reporter: Murali Krishna P
>            Priority: Major
>         Attachments: LUCENE-8601.01.patch, LUCENE-8601.02.patch, LUCENE-8601.03.patch,
LUCENE-8601.04.patch, LUCENE-8601.05.patch, LUCENE-8601.06.patch, LUCENE-8601.patch
>
>
> Today, we can write a custom Field using custom IndexFieldType, but when the DefaultIndexingChain
converts [IndexFieldType to FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java#L662],
only few key informations such as indexing options and doc value type are retained. The [Codec
gets the FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L90],
but not the type details.
>   
>  FieldInfo has support for ['attributes'| https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L47]
and it would be great if we can add 'attributes' to IndexFieldType also and copy it to FieldInfo's
'attribute'.
>   
>  This would allow someone to write a custom codec (extending docvalueformat for example)
for only the 'special field' that he wants and delegate the rest of the fields to the default
codec.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message