lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8640) validate delimiters when parsing date ranges
Date Sun, 20 Jan 2019 04:43:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747335#comment-16747335
] 

David Smiley commented on LUCENE-8640:
--------------------------------------

Better but still the integer gets parsed twice.  I suggest making {{isValidDateValue}} actually
_return_ the integer it parses... and then rename to "parseIntegerAndValidate" or something.

> validate delimiters when parsing date ranges
> --------------------------------------------
>
>                 Key: LUCENE-8640
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8640
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: Mikhail Khludnev
>            Priority: Major
>         Attachments: LUCENE-8640.patch, LUCENE-8640.patch, mypatch.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {{DateRangePrefixTree.parseCalendar()}} should validate delimiters to rejects dates like
{{2000-11T13}} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message