lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8642) RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
Date Thu, 17 Jan 2019 11:26:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744912#comment-16744912
] 

ASF subversion and git services commented on LUCENE-8642:
---------------------------------------------------------

Commit ffd8e88774e0eefbcb41720d7a4713f3cf6ad90c in lucene-solr's branch refs/heads/branch_7x
from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ffd8e88 ]

LUCENE-8642, LUCENE-8641: correct RamUsageTester.sizeOf's handling of ByteBuffers. Throw exceptions
on denied reflection to catch problems early. This affects tests only.


> RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-8642
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8642
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>
> We have a silent fall-through on catch clause there if a field is inaccessible. This
causes all collections to not be recursively descended into.
> We could hack it so that collection objects are counted "manually". Or we could propagate
illegal access exception from ram tester, detect which tests/ objects do try to measure collection
objects and either remove them (if it's not possible to measure accurately) or change them
(if it is possible to estimate the size in a different way).
> Looking for feedback on this one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message