lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8642) RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
Date Thu, 17 Jan 2019 11:44:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744943#comment-16744943
] 

Alan Woodward commented on LUCENE-8642:
---------------------------------------

This looks like it might have broken compilation on 7x and 8x?
*11:35:34* common.compile-core:*11:35:34*     [mkdir] Created dir: /var/lib/jenkins/workspace/apache+lucene-solr+branch_8x/lucene/build/test-framework/classes/java*11:35:34*
    [javac] Compiling 196 source files to /var/lib/jenkins/workspace/apache+lucene-solr+branch_8x/lucene/build/test-framework/classes/java*11:35:35*
    [javac] /var/lib/jenkins/workspace/apache+lucene-solr+branch_8x/lucene/test-framework/src/java/org/apache/lucene/util/RamUsageTester.java:160:
error: cannot find symbol*11:35:35*     [javac]             } else if (ob instanceof ByteBuffer)
{*11:35:35*     [javac]                                      ^*11:35:35*     [javac]   symbol:
  class ByteBuffer*11:35:35*     [javac]   location: class RamUsageTester*11:35:35*     [javac]
/var/lib/jenkins/workspace/apache+lucene-solr+branch_8x/lucene/test-framework/src/java/org/apache/lucene/util/RamUsageTester.java:162:
error: cannot find symbol*11:35:35*     [javac]               totalSize += byteArraySize(((ByteBuffer)
ob).capacity());*11:35:35*     [javac]                                            ^*11:35:35*
    [javac]   symbol:   class ByteBuffer*11:35:35*     [javac]   location: class RamUsageTester*11:35:35*
    [javac] Note: Some input files use or override a deprecated API.*11:35:35*     [javac]
Note: Recompile with -Xlint:deprecation for details.*11:35:35*     [javac] 2 errors*11:35:35*
*11:35:35* BUILD FAILED
 

> RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-8642
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8642
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: master (9.0)
>
>
> We have a silent fall-through on catch clause there if a field is inaccessible. This
causes all collections to not be recursively descended into.
> We could hack it so that collection objects are counted "manually". Or we could propagate
illegal access exception from ram tester, detect which tests/ objects do try to measure collection
objects and either remove them (if it's not possible to measure accurately) or change them
(if it is possible to estimate the size in a different way).
> Looking for feedback on this one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message