lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8642) RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
Date Thu, 17 Jan 2019 11:49:00 GMT


ASF subversion and git services commented on LUCENE-8642:

Commit 7bcad94325c1c4168d35a23fa35850f245dafb80 in lucene-solr's branch refs/heads/branch_8x
from Dawid Weiss
[;h=7bcad94 ]

Revert "LUCENE-8642, LUCENE-8641: correct RamUsageTester.sizeOf's handling of ByteBuffers.
Throw exceptions on denied reflection to catch problems early. This affects tests only."

This reverts commit b4524d902df8536887b0caa108634fee8599b65c.

> RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
> -----------------------------------------------------------------------------
>                 Key: LUCENE-8642
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: master (9.0)
> We have a silent fall-through on catch clause there if a field is inaccessible. This
causes all collections to not be recursively descended into.
> We could hack it so that collection objects are counted "manually". Or we could propagate
illegal access exception from ram tester, detect which tests/ objects do try to measure collection
objects and either remove them (if it's not possible to measure accurately) or change them
(if it is possible to estimate the size in a different way).
> Looking for feedback on this one.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message