lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12461) Upgrade Dropwizard Metrics to 4.0.2 release
Date Mon, 15 Apr 2019 18:46:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818270#comment-16818270
] 

Andrzej Bialecki  commented on SOLR-12461:
------------------------------------------

This patch upgrades the library and removes the support for Ganglia. I'm not sure what to
do about back-compat - basically, it's not possible to support Ganglia without reimplementing
that module, and again adding transitive LGPL dependencies, and if we were to stick strictly
to supporting it through all 8.x releases then we wouldn't be able to upgrade.

Is an upgrade note in CHANGES describing the reasons for removal sufficient in this case?

> Upgrade Dropwizard Metrics to 4.0.2 release
> -------------------------------------------
>
>                 Key: SOLR-12461
>                 URL: https://issues.apache.org/jira/browse/SOLR-12461
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Major
>         Attachments: SOLR-12461.patch
>
>
> This version of the library contains several improvements and it's compatible with Java
9. 
> However, starting from 4.0.0 metrics-ganglia is no longer available, which means that
if we upgrade we will have to remove the corresponding {{SolrGangliaReporter}}.
> Such change is not back-compatible, so I see the following options:
> * wait with the upgrade until 8.0
> * upgrade and remove {{SolrGangliaReporter}} and describe this in the release notes.
> Any other suggestions?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message