lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13331) Atomic Update Multivalue remove does not work
Date Sat, 13 Apr 2019 02:33:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816802#comment-16816802
] 

ASF subversion and git services commented on SOLR-13331:
--------------------------------------------------------

Commit cfddbe1126523f84b9d7f7f98c55af9e8fd0f405 in lucene-solr's branch refs/heads/branch_7_7
from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cfddbe1 ]

SOLR-13331: Fix AtomicUpdate 'remove' ops in SolrJ

The racent change introducing ByteArrayUtf8CharSequence altered the
NamedLists produced by atomic-update requests so that they include
instances of this class for requests coming in as javabin.  This is a
problem for 'remove' atomic-updates, which need to be able to compare
these ByteArrayUtf8CharSequence instances with existing field values
represented as Strings.  equals() would always return false, and
'remove' operations would have no effect.

This commit converts items as necessary to allow atomic-update
operations to work as expected.


> Atomic Update Multivalue remove does not work
> ---------------------------------------------
>
>                 Key: SOLR-13331
>                 URL: https://issues.apache.org/jira/browse/SOLR-13331
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: UpdateRequestProcessors
>    Affects Versions: 7.7, 7.7.1, 8.0
>         Environment: Standalone Solr Server
>            Reporter: Thomas Wöckinger
>            Assignee: Jason Gerlowski
>            Priority: Critical
>              Labels: patch
>             Fix For: 8.1, master (9.0)
>
>         Attachments: Fix-SOLR13331-Add-toNativeType-implementations.patch, SOLR-13331.patch
>
>
> When using JavaBinCodec the values of collections are of type ByteArrayUtf8CharSequence,
existing field values are Strings so the remove Operation does not have any effect.
> The relevant code is located in class AtomicUpdateDocumentMerger method doRemove.
> The method parameter fieldVal contains the collection values of type ByteArrayUtf8CharSequence,
the variable original contains the collection of Strings



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message