lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13400) Replace Observable pattern in TransientSolrCoreCache
Date Sat, 20 Apr 2019 00:36:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822285#comment-16822285
] 

ASF subversion and git services commented on SOLR-13400:
--------------------------------------------------------

Commit 5aaa923e360bc5c670230445bb710d07ba4a4655 in lucene-solr's branch refs/heads/master
from Uwe Schindler
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5aaa923 ]

LUCENE-8738, SOLR-13400: Remove obsolete changes entry (replaced by SOLR-13400)


> Replace Observable pattern in TransientSolrCoreCache
> ----------------------------------------------------
>
>                 Key: SOLR-13400
>                 URL: https://issues.apache.org/jira/browse/SOLR-13400
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Server, SolrCloud
>    Affects Versions: 8.0, master (9.0)
>            Reporter: Uwe Schindler
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 8.1, master (9.0)
>
>         Attachments: SOLR-13400-8x.patch, SOLR-13400-master.patch, SOLR-13400.patch
>
>
> Due to change to Java 11 as minimum version (LUCENE-8738), the usage of the old java.utilObservable
pattern is deprecated and cannot be used anymore in Lucene/Solr.
> LUCENE-8738 added a rewritten, more type-safe oimplementation of the observer pattern,
but it looks like the is overengenieered. As there is only one listener registered, it would
be enough to just call the method on SolrCores class (pkg-protected). On LUCENE-8738, [~erickerickson]
suggested to move the callback method to queue closes of core in CoreContainer instead, so
all the abstractions can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message