lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ZhaoYang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8765) OneDimensionBKDWriter valueCount validation didn't include leafCount
Date Wed, 17 Apr 2019 15:39:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820212#comment-16820212
] 

ZhaoYang commented on LUCENE-8765:
----------------------------------

Thanks for the feedback, updated the patch with {{expectThrows}}

> OneDimensionBKDWriter valueCount validation didn't include leafCount
> --------------------------------------------------------------------
>
>                 Key: LUCENE-8765
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8765
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 7.5, master (9.0)
>            Reporter: ZhaoYang
>            Priority: Minor
>         Attachments: 0001-Fix-OneDimensionBKDWriter-valueCount-validation-v2.patch, 0001-Fix-OneDimensionBKDWriter-valueCount-validation.patch
>
>
> {{[OneDimensionBKDWriter#add|https://github.com/jasonstack/lucene-solr/blob/branch_7_5/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L612]}}
checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but {{valueCount}} is only
updated for every 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points. 
> We should include {{leafCount}} for validation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message