lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] msokolov commented on a change in pull request #657: LUCENE-8781: FST direct arc addressing
Date Fri, 03 May 2019 18:46:24 GMT
msokolov commented on a change in pull request #657: LUCENE-8781: FST direct arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#discussion_r280887930
 
 

 ##########
 File path: lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsSegmentTermsEnum.java
 ##########
 @@ -1082,12 +1082,14 @@ private InputOutput getByOutput(long targetOrd) throws IOException
{
       if (FST.targetHasArcs(arc)) {
         // System.out.println("  targetHasArcs");
         result.grow(1+upto);
-        
+        if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
 
 Review comment:
   @dweiss I think I addressed your comments and this is ready to be committed. If you agree,
would you be able to help with that (I'm not a committer, so I need help!)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message