lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] mikemccand commented on a change in pull request #664: LUCENE-8785: Ensure threadstates are locked before iterating
Date Tue, 07 May 2019 18:40:59 GMT
mikemccand commented on a change in pull request #664: LUCENE-8785: Ensure threadstates are
locked before iterating
URL: https://github.com/apache/lucene-solr/pull/664#discussion_r281777717
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java
 ##########
 @@ -287,8 +287,8 @@ synchronized Closeable lockAndAbortAll() throws IOException {
     };
     try {
       deleteQueue.clear();
-      final int limit = perThreadPool.getMaxThreadStates();
       perThreadPool.lockNewThreadStates();
+      final int limit = perThreadPool.getMaxThreadStates();
 
 Review comment:
   Wow, subtle!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message