lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] uschindler commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
Date Wed, 08 May 2019 06:56:27 GMT
uschindler commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
URL: https://github.com/apache/lucene-solr/pull/666#discussion_r281935086
 
 

 ##########
 File path: lucene/tools/forbiddenApis/solr.txt
 ##########
 @@ -55,3 +55,8 @@ com.google.common.base.Preconditions#checkNotNull(java.lang.Object,java.lang.Obj
 @defaultMessage Use methods in java.util.Comparator instead
 com.google.common.collect.Ordering
 
+@defaultMessage Use corresponding classes in package org.apache.solr.common.json instead
 
 Review comment:
   I'd propose to just add `org.noggit.**`, this disallows whole package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message