lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.5
Date Tue, 21 May 2019 20:04:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845208#comment-16845208
] 

Erick Erickson commented on SOLR-8346:
--------------------------------------

Here’s a preliminary patch. Current state:

1> precommit passes if I take out the //nocommits
2> These two tests fail:
   [junit4]   - org.apache.solr.cloud.ZkCLITest (suite) (zombie threads)
   [junit4]   - org.apache.solr.cloud.OutOfBoxZkACLAndCredentialsProvidersTest.testOpenACLUnsafeAllover
(I have no idea)

Things I’d like some different eyes on:

- I created some new files in solr/licenses for the addition al jute jar by just copying the
other zookeeper files over, is this OK?

- I didn’t dig into the test failures, any clues?

- ZkTestServer probably got the most surgery, any eyes there would be good.
— One bit in particular is that there are two more event types in the switch statement in
updateForFire that I just stuck in as no-ops

- see the nocommits still in the code

- I broke out the version and separate jars in ivy-versions, does that look OK?

Overall I’m reasonably optimistic if we can get the two failing tests to pass, all help
gladly accepted.


> Upgrade Zookeeper to version 3.5.5
> ----------------------------------
>
>                 Key: SOLR-8346
>                 URL: https://issues.apache.org/jira/browse/SOLR-8346
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud
>            Reporter: Jan Høydahl
>            Priority: Major
>              Labels: security, zookeeper
>         Attachments: SOLR-8346.patch, SOLR-8346.patch, SOLR_8346.patch
>
>
> Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation for this
is SSL support. --Currently a 3.5.4-beta is released (2018-05-17).-- Version 3.5.5 was released
2019-05-20



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message