lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8346) Upgrade Zookeeper to version 3.5.5
Date Thu, 30 May 2019 03:20:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851487#comment-16851487
] 

Erick Erickson commented on SOLR-8346:
--------------------------------------

All tests pass. Precommit doesn't quite yet since I have a few nocommits in there. These mark
the bits I would appreciate other eyes on. This is people's chance to look at them as I'll
commit this this weekend unless there are objections.

The nocommits are:
ZookeeperStatusHandler.monitorZooKeeper. This generated an NPE before I figured out about
ZKs whitelist. I think this as it should be, you can't write code like 
{code}
obj.put(line.split("\t")[0], line.split("\t")[1]);
{code}
and not expect NPEs

ZkCliTest and SolrZkClient. There was an un-released object regularly, and the two changes
to these files made the test pass. What I'm a little uncomfortable about is why this was unnecessary
before.

ZkTestServer. There are a couple of new constants that I just stuck in a Switch statement
as no-ops. The other two nocommits have to do with selectorThread being part of an overridden
method. Just removing the overridden method doesn't seem to matter.

Despite the size of the patch, there isn't much in the way of substantive code changes. There's
a _lot_ of changes since one of the ZK methods takes a Path rather than a String. Although
I can't quite see why now... Siiigggh... Still, it's not a bad cleanup...

One thing that's different for all the tests is that the 4-letter words are disabled (except
'srvr') by default with this release of ZK. Since it was wide open before, I set the ZooKeeper
Whitelist to "*" in SolrTestCaseJ4. If we want to test specific ACL  we should open up a separate
JIRA I think. I looked at the ZK test code, and _only_ saw the 4-letter commands enabled through
setting a sysprop, so I don't think it's unreasonable for us to do that too.

Still to do: Like, you know, try to run Solr against ZK 3.5.5. I'm anticipating some changes
for ZKs whitelist. But otherwise I'm ready to commit this, absent feedback I'll take out the
nocommits and make sure precommit runs and push it this weekend.

I'll be traveling the next couple of days so may be intermittent when responding...

> Upgrade Zookeeper to version 3.5.5
> ----------------------------------
>
>                 Key: SOLR-8346
>                 URL: https://issues.apache.org/jira/browse/SOLR-8346
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud
>            Reporter: Jan H√łydahl
>            Assignee: Erick Erickson
>            Priority: Major
>              Labels: security, zookeeper
>         Attachments: SOLR-8346.patch, SOLR-8346.patch, SOLR-8346.patch, SOLR_8346.patch
>
>
> Investigate upgrading ZooKeeper to 3.5.x, once released. Primary motivation for this
is SSL support. --Currently a 3.5.4-beta is released (2018-05-17).-- Version 3.5.5 was released
2019-05-20



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message