lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Commented] (SOLR-12562) Clean up RealTimeGetComponent.toSolrDoc
Date Fri, 24 May 2019 18:28:00 GMT


Erick Erickson commented on SOLR-12562:

Updated patch, if all goes well I'll commit this weekend. It incorporates (I think) your suggestions

I looked at TestRealTimeGet and it looks like it incorporates all of the variants, so this
feels pretty solid.

Precommit and all tests pass. I'll enable patch review too.

> Clean up RealTimeGetComponent.toSolrDoc
> ---------------------------------------
>                 Key: SOLR-12562
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-12562.patch, SOLR-12562.patch
> This code looks really redundant so we should remove one. The one in RealTimeGet is the
only used locally so my vote is to remove that one.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message