lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12562) Clean up RealTimeGetComponent.toSolrDoc
Date Fri, 24 May 2019 20:38:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847883#comment-16847883
] 

Erick Erickson commented on SOLR-12562:
---------------------------------------

I did just check and TestRealTimeGet exercises all the code paths that have been changed _except_
the one where the SchemaField is not found, which is what we expect.

That code path logs a warning FWIW. If I force the schema field to be null, then the old code
fails too.

> Clean up RealTimeGetComponent.toSolrDoc
> ---------------------------------------
>
>                 Key: SOLR-12562
>                 URL: https://issues.apache.org/jira/browse/SOLR-12562
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-12562.patch, SOLR-12562.patch
>
>
> This code looks really redundant so we should remove one. The one in RealTimeGet is the
only used locally so my vote is to remove that one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message